feat: add Redis username authentication support#66
Merged
michalsn merged 1 commit intocodeigniter4:developfrom Aug 19, 2025
Merged
feat: add Redis username authentication support#66michalsn merged 1 commit intocodeigniter4:developfrom
michalsn merged 1 commit intocodeigniter4:developfrom
Conversation
michalsn
requested changes
Jul 24, 2025
Member
michalsn
left a comment
michalsn
left a comment
There was a problem hiding this comment.
@formbay-sanil Thank you for sending a PR.
Please follow the failed checks: use isset instead of empty. Also run composer cs-fix to apply proper code styling.
formbay-sanil
force-pushed
the
feat/redis-username-auth
branch
2 times, most recently
from
fb5b67c to
080f914
Compare
Member
|
@formbay-sanil Thank you! Can you try to sign your commit? Here are some handy instructions: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#gpg-signing-old-commits |
Member
|
And some info about code signing in general: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/signing.md |
- Add username config option to Redis configuration - Support both username+password and password-only auth methods - Maintain backward compatibility with existing password-only setups - Improve error messages for authentication failures Signed-off-by: Sanil Shrestha <sanil.shrestha@formbay.com.au>
formbay-sanil
force-pushed
the
feat/redis-username-auth
branch
from
080f914 to
171e23d
Compare
michalsn
approved these changes
Jul 25, 2025
maniaba
reviewed
Aug 1, 2025
maniaba
left a comment
maniaba
left a comment
There was a problem hiding this comment.
Consider adding a PHPUnit test for this part to ensure it's properly covered.
Member
|
Thank you @formbay-sanil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Explain what you have changed, and why.
Checklist: